DOC: add to README so example works under Python 3.6 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So no TypeError under Python 3.6
|
I am another victim of this minor detail.... please review and merge maintainers. |
itamarhaber
approved these changes
May 8, 2019
itamarhaber
approved these changes
May 8, 2019
itamarhaber
added a commit
to itamarhaber/rejson-py
that referenced
this pull request
May 8, 2019
In lieu of RedisJSON#21 as merging appears disabled.
gkorland
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement?
It adds
decode_responses=Truein the example in README.rst as mentioned in #8 (comment) (which took me too long to find after copy/pasting the example with Python 3.6.5 and rejson-py 0.3.0).