Dockerfile optimizations #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d step and deleting unneeded package installation files. Add non-interactive env vars.
|
@pataquets one small thing - could you also test whether adding |
…harmful build errors.
…ld time and make image smaller (#70).
|
@itamarhaber : Done. Works for me, it didn't broke. |
|
Thanks @pataquets - merged. |
yaacovhazan-Redislabs
pushed a commit
that referenced
this pull request
Mar 18, 2020
* Optimize final image build size by grouping commands in the same build step and deleting unneeded package installation files. Add non-interactive env vars. * Add non-interactive env vars to builder apt-get. Readability. * apt-get switches: be less forceful to allow detection of potentially harmful build errors. * Add '--no-install-recommends' switch to apt-get command to reduce build time and make image smaller (#70). * Add testing Docker Compose manifests. * Dockerfile: Get source files from local build context instead of downloading from git. * Docker Compose example manifests: Build from local context. Uncomment example options. * Readme: Document Docker Compose manifest usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize final image build size by grouping commands in the same build step and deleting unneeded package installation files. Add non-interactive env vars.