Skip to content

Improve Cholesky variants #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Improve Cholesky variants #889

merged 1 commit into from
Aug 11, 2023

Conversation

angsch
Copy link
Collaborator

@angsch angsch commented Aug 9, 2023

Make the Cholesky variants a bit more competitive by replacing the scalar potf2 with the recursive potrf2. The latter is already used in the primary Cholesky factorization (SRC/dpotrf.f etc.) .

Replace the scalar potf2 with the recursive potrf2 implementation.
The latter is already used in the default Cholesky factorization.
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (129637e) 0.00% compared to head (57c9238) 0.00%.

❗ Current head 57c9238 differs from pull request most recent head 8e4ad31. Consider uploading reports for the commit 8e4ad31 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #889   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1918     1918           
  Lines      188614   188614           
=======================================
  Misses     188614   188614           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@langou
Copy link
Contributor

langou commented Aug 11, 2023

Thanks @angsch. There is also the question of the variant of the "main" POTRF in LAPACK. Right now I think LAPACK/SRC is using the left-looking variant. This is fine with me, but maybe using the plain recursive variant or the right-looking one would be better. (Preference for recursive.) I am comfortable if we leave things as they are.

@langou langou merged commit 47fd4fd into Reference-LAPACK:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants