User search, ratings data from local db #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weex
reviewed
Mar 18, 2017
| @@ -0,0 +1,8 @@ | |||
| /*! | |||
There was a problem hiding this comment.
Please commit and link in only the unminified version of this and the datatables css files. Later we can have a build script that minifies but let's keep things unminified for easy/possible review.
Also, please document the source commit or online generator steps that gave you these files, so independent verification is also possible.
There was a problem hiding this comment.
I verified the source of these two dataTables.bootstrap files as matching DataTables-1.10.13
| """Gets the average rating a user (identified by his msin) has received | ||
| along with the number of ratings he has received""" | ||
|
|
||
| sel_url = "{0}query?owner={1}&delegate={2}&query=get_user_ratings&testnet={3}&msin={4}" |
There was a problem hiding this comment.
If we don't query for ratings from the server here, where and when do we still obtain ratings and put them in our local client database?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.