Skip to content

Use a shared engine for all the tests #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2022
Merged

Use a shared engine for all the tests #26

merged 4 commits into from
Nov 11, 2022

Conversation

miazamrai
Copy link
Contributor

Creating and deleting engine once during all the tests.

@miazamrai miazamrai requested review from NRHelmi and larf311 November 11, 2022 12:53
@miazamrai miazamrai changed the title Use a shared engine for tests Use a shared engine for all the tests Nov 11, 2022
@miazamrai miazamrai marked this pull request as draft November 11, 2022 13:06
@miazamrai miazamrai marked this pull request as ready for review November 11, 2022 13:20
NRHelmi
NRHelmi approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@NRHelmi NRHelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @miazamrai

@miazamrai miazamrai merged commit 9732ef7 into main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larf311 larf311 Awaiting requested review from larf311

1 more reviewer

@NRHelmi NRHelmi NRHelmi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miazamrai @NRHelmi