-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: use etelemetry to check for a newer version available upon running a command or importing .api #493
Conversation
…ng a command or importing .api It already helped me to realize that I forgot to "release" 0.2.* on Github. Now they are released, so I guess it takes etemetry service some time to update its knowledge. Hopefully tomorrow we should see the effect.
i think that would be good. |
oh, and you have a similar one in nipype (which you pointed out in nipy/heudiconv#392) |
From a user perspective, I very much dislike a tool or library reaching out to a server each time it is invoked, for activity unrelated to anything I explicitly requested or wanted. Please consider making this opt-in or at least opt-out. |
@kyleam - don't you do that every time you use the browser or any app on your phone? |
Using a browser is a very specific request by me to connect to servers. We're talking about a local python library/command-line tool that does not even require an internet connection for many operations. I should be able to use a local tool on my computer without it phoning a server. |
but your apps are local and they do tell you updates are available. i think providing a way for developers to communicate with their users to notify bad versions, updates is a good thing. i understand the philosophy, and ET does allow a way to disable it and handles no connection uses, but i am saying that most apps today communicate with servers. i don't necessarily see that as concern if we ensure that people know that the app (even if it's a python tool on the command line) will communicate. |
I believe there is a possibility to opt-out via env variable ( |
[ Sorry, I ignored the smartphone part of your reply since I don't use one. :/ ] Even if you assume that your users are comfortable with their smartphones behaving this way (most of them probably are), that doesn't mean that they expect or prefer their, say, Debian systems to behave that way. And given that reproman isn't being used on smartphones, the latter is much more relevant.
I agree with that. But as this PR stands (it's of course still work-in-progress) it doesn't look like we do anything to ensure that users know this or advertise how they can disable it. |
Thanks. |
Eventually some generalization of ReproNim/reproman#493 should become part of etelemetry, and thus avoiding redoing it here. Thus fix is minimal Closes nipy#405
Eventually some generalization of ReproNim/reproman#493 should become part of etelemetry, and thus avoiding redoing it here. Thus fix is minimal Closes nipy#405
superseded with smaller #564 |
It already helped me to realize that I forgot to "release" 0.2.* on Github.
Now they are released, so I guess it takes etelemetry service some time to update
its knowledge. Hopefully tomorrow we should see the effect.
Attn @satra who might provide recommendation and also I wonder if it would be worth trying to generalize such
check_available_version
and ship it within etelemtry-client itself, so users did not have to reimplement similar logic. Could have signature likewhere
info
anddebug
will be the callable (with the same signature as of the logger) to use. What do you think @satra ?TODOs: