chore: make validate currency as public method #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrylaloan
requested review from
benjlevesque,
alexandre-abrioux,
leoslr and
yomarion
benjlevesque
approved these changes
Jun 19, 2023
| if ( | ||
| currency.type === RequestLogicTypes.CURRENCY.ISO4217 || | ||
| currency.type === RequestLogicTypes.CURRENCY.ETH || | ||
| currency.type === RequestLogicTypes.CURRENCY.BTC | ||
| ) | ||
| return true; | ||
| return this.validateAddress(currency.value, currency); | ||
| return CurrencyManager.validateAddress(currency.value, currency); |
There was a problem hiding this comment.
shouldn't validateAddress also be moved to an instance method rather than static? For the same reason you changed validateCurrency (ability to override behaviour)
There was a problem hiding this comment.
let's update validateAddress as well 👍
alexandre-abrioux
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
The same remark as @benjlevesque; other than that it looks good to me!
MantisClone
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
The purpose of this change is to allow users to provide a custom
validateCurrency&validateAddressmethod for currency which not supported by the library.Updated: