feat: payment processor batch payment native token #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoslr
requested review from
benjlevesque,
alexandre-abrioux and
olivier7delf
github-actions
bot
requested review from
kevindavee,
MantisClone and
yomarion
alexandre-abrioux
approved these changes
Oct 26, 2023
packages/payment-processor/src/payment/batch-conversion-proxy.ts
Outdated
Show resolved
Hide resolved
packages/payment-processor/src/payment/batch-conversion-proxy.ts
Outdated
Show resolved
Hide resolved
packages/payment-processor/src/payment/batch-conversion-proxy.ts
Outdated
Show resolved
Hide resolved
olivier7delf
approved these changes
Oct 26, 2023
|
Great job Leo! |
It's done in this test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Payment-processor supports for batch payment of ETH requests with / without conversion.
Additional change:
Add and use
ETH-privateinstead of usingETH-mainneton local chain.