Skip to content

fix: Flashing pdf beneath the single invoice #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

fix: Flashing pdf beneath the single invoice #333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d3edc3
fix: flashing pdf beneath the single invoice
sstefdev Feb 3, 2025
fc9b890
Merge branch 'main' into 325-single-invoice-page-displays-preview-fla…
MantisClone Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 34 additions & 6 deletions shared/utils/generateInvoice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ async function ensureHtml2PdfLoaded() {
export const exportToPDF = async (
invoice: Types.IRequestDataWithEvents,
currency?: CurrencyTypes.CurrencyDefinition,
paymentCurrencies?: (CurrencyTypes.ERC20Currency | CurrencyTypes.NativeCurrency | undefined)[],
paymentCurrencies?: (
| CurrencyTypes.ERC20Currency
| CurrencyTypes.NativeCurrency
| undefined
)[],
logo?: string
) => {
await ensureHtml2PdfLoaded();
Expand Down Expand Up @@ -79,7 +83,7 @@ export const exportToPDF = async (
<div id="invoice" style="max-width: 680px; margin: 0 auto; padding: 20px;">
<div style="display: flex; justify-content: space-between; align-items: start;">
${logo && logo.length > 0 ? `<img src="${logo}" alt="Logo" style="width: 50px; height: 50px;">` : ""}
<div style="text-align: right;">
<div style="text-align: right; min-width: 150px; width: auto;">
<p>Issued on ${formatDate(invoice.contentData?.creationDate)}</p>
<p>Payment due by ${formatDate(invoice.contentData?.paymentTerms?.dueDate)}</p>
</div>
Expand Down Expand Up @@ -198,11 +202,35 @@ export const exportToPDF = async (
},
};

// Create a hidden container
const container = document.createElement("div");
container.style.cssText = `
position: fixed;
left: -9999px;
top: -9999px;
height: 0;
overflow: hidden;
opacity: 0;
pointer-events: none;
`;

// Create the actual content element (this will be rendered in the PDF)
const element = document.createElement("div");
element.innerHTML = content;
document.body.appendChild(element);

await window.html2pdf().from(element).set(opt).save();

document.body.removeChild(element);
// Add the content element to the hidden container
container.appendChild(element);
document.body.appendChild(container);

try {
await window
.html2pdf()
.from(element) // Use the inner element for PDF generation
.set(opt)
.save();
} finally {
if (document.body.contains(container)) {
document.body.removeChild(container);
}
}
};