Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnet links don't work #410

Closed
msxfm opened this issue Jul 7, 2014 · 5 comments
Closed

Magnet links don't work #410

msxfm opened this issue Jul 7, 2014 · 5 comments
Milestone

Comments

@msxfm
Copy link

msxfm commented Jul 7, 2014

Issue by scstanton
Wednesday Nov 20, 2013 at 15:30 GMT
Originally opened as RequestPolicy/requestpolicy#410


After installing the beta, magnet: links no longer invoke my torrent client.

@msxfm
Copy link
Author

msxfm commented Jul 7, 2014

Comment by cryptonot
Thursday Nov 21, 2013 at 22:22 GMT


Now that I've tested it, I have the same issue. Tried it on multiple FF profiles. Only way to use the links is copying them.

@nodiscc
Copy link
Contributor

nodiscc commented Aug 19, 2014

Reproducible every time for me. It looks like RP breaks all links that do not point to http:// or https:// URIs.

I use RP in blacklist mode (the default is to allow everything), so I don't think it's related the default allow/deny policy. I can confirm the addon at least breaks magnet: and mailto: links. Disable blocking seems to work around this problem.

Related bugs:

Should we rename this bug to something like Breaks all non-http/https links and use it as a tracking bug?

@nodiscc nodiscc added the bug label Aug 19, 2014
@myrdd
Copy link
Member

myrdd commented Aug 20, 2014

Should we rename this bug to something like Breaks all non-http/https links and use it as a tracking bug?

In the long run I'd like to solve this by displaying blocked URI schemes (see nsIURI) in the menu, and maybe we might show a notification bar (like we do when a redirect is blocked).

Should this be solved until 1.0.0? At least the mailto link, of course. But I don't like to hardcode schemes like UT2004, and also I think it's a good idea to block cross-URI-scheme requests by default. But, we could allow them for link-clicks. What do you think?

Thanks for the putting those issues together, @nodiscc. But why did you link to the old repository sometimes? I'd suggest to always link to the new repository.

@myrdd
Copy link
Member

myrdd commented Aug 20, 2014

I've created a new issue including a proposal to solve all those issues: #447

@myrdd
Copy link
Member

myrdd commented Nov 10, 2014

@scstanton @cryptonot
version 1.0.beta8 contains a workaround against this bug, so I close this issue. For details take a look at issue #447, it aims to solve this problem cleanly.

@myrdd myrdd closed this as completed Nov 10, 2014
@myrdd myrdd added this to the 1.0.beta8 milestone Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants