Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fixes #92

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Docs fixes #92

merged 3 commits into from
Sep 25, 2020

Conversation

simleo
Copy link
Contributor

@simleo simleo commented Sep 18, 2020

Fixes an id reference and some typos.

stain pushed a commit that referenced this pull request Sep 25, 2020
Incorporates 89a2a3c and becc91b in #92

Signed-off-by: Stian Soiland-Reyes <stain@apache.org>
@stain stain merged commit f32bbc7 into ResearchObject:master Sep 25, 2020
@stain
Copy link
Contributor

stain commented Sep 25, 2020

Thanks @simleo! Merged into the split versions from #95

I did not change the past version as we would need to do a new patch release for typo fixes. We've tended to only fix syntactic bugs.

I did not include 63f6c5f as describing your own encoding format in a neighboring file sounds more like an edge case. It is true that the use of commonwl URI as example there is odd, as it will be an impedance mismatch with the use of programmingLanguage later in Workflows sections. Perhaps have a new issue for that.

@simleo simleo deleted the docs_fixes branch September 25, 2020 15:43
@stain stain added this to the RO-Crate 1.1 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants