Fix for issue #75 - Graceful shutdown feature implementation #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,12 @@ | |||
|
|
|||
| package org.mobicents.slee.resource; | |||
|
|
|||
| import java.io.Serializable; | |||
| import org.apache.log4j.Logger; | |||
| import org.mobicents.slee.container.resource.GracefullyStopableResourceAdaptor; | |||
There was a problem hiding this comment.
is this new interface part of this PR?
It seems its not even on your repo https://github.com/gfigiel/jain-slee/tree/2.x-gracefulshutdown/container/resource/src/main/java/org/mobicents/slee/resource
maybe you missed to git add the new file...? hopefully it is safe on your workspace
added 2 commits
September 6, 2016 14:00
…ibutions/gracefull-shutdown/jain-slee into 2.x-gracefulshutdown
|
Hello, Br, |
|
Closed as test status is not certain. Branch with fixes will be recreated when tests are finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the implementation of graceful stoping mode implementation required for graceful shutdown feature.
As to utilize the feature the supporting RA must implement org.mobicents.slee.container.resource.GracefullyStopableResourceAdaptor interface.
Separate process shall monitor supporting RA activities state to finally shutdown the container.