fix logic error hashing small files from CD filesystem #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/310192285306454017/645777658319208448/1197203036334985297
When reading a file smaller than 2048 bytes, the entire sector containing the file was being hashed. This was unintentional.
However, fixing this issue will cause most of the PSP hashes to change. As such, we will need to support both old and new hashes for the ~1000 PSP hashes already in the system.
This function is also used for NeoGeoCD, Dreamcast, PSX, and PS2 hashes, but the likelihood of those having files smaller than 2048 bytes is basically non-existant.