Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor #1016

Merged
merged 8 commits into from
Jan 26, 2019
Merged

Fix editor #1016

merged 8 commits into from
Jan 26, 2019

Conversation

Flamefire
Copy link
Member

@Flamefire Flamefire commented Jan 22, 2019 •
edited
Loading

Pulls in the fix for destroyed textures and wrong BQ in the editor.

Also some tests created while refactoring Point/Rect (used by the editor)

@Flamefire Flamefire mentioned this pull request Jan 22, 2019
Closed
@Flamefire Flamefire changed the title Fix editor WIP: Fix editor Jan 22, 2019
@Flamefire Flamefire force-pushed the Fix_Editor branch 2 times, most recently from 726e5f7 to 93474da Compare January 23, 2019 09:24
stefson
stefson previously approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@stefson stefson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked out your branch, it compiles fine on amd64 and as a result, the editor is now free of glitches.

@Flamefire Flamefire changed the title WIP: Fix editor Fix editor Jan 23, 2019
@Flamefire Flamefire requested a review from Flow86 January 23, 2019 20:13
@Flamefire Flamefire merged commit 3f6c4bb into Return-To-The-Roots:master Jan 26, 2019
@Flamefire Flamefire deleted the Fix_Editor branch January 26, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flow86 Flow86 Flow86 approved these changes

@stefson stefson stefson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Flamefire @Flow86 @stefson