Paywalls: improve error display
#1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 218 218
Lines 7199 7199
Branches 1007 1007
=======================================
Hits 6060 6060
Misses 748 748
Partials 391 391 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Jan 17, 2024
| return | ||
| } | ||
|
|
||
| assertThat(state.errorMessage).isEqualTo("Error 10: Error performing request.") |
NachoSoto
pushed a commit
that referenced
this pull request
Jan 17, 2024
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: improve error display (#1558) via NachoSoto (@NachoSoto) * Fix paywall dialog composable sizing issues (#1556) via Toni Rico (@tonidero) * `Paywalls`: improve landscape layout on all templates (#1551) via NachoSoto (@NachoSoto) ### Bugfixes * Fix AmazonConfiguration for Java projects (#1554) via Cesar de la Vega (@vegaro) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `0ddee10` to `e6ba247` (#1557) via dependabot[bot] (@dependabot[bot]) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to RevenueCat/purchases-ios#3577
I've also added test coverage for errors in
PaywallViewModel.Before
After