Integration Tests: improve flaky tests
#3584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/17208/workflows/729d01a6-d644-446c-8514-80b54177ff43/jobs/162052/tests With #3140 and faster executors in CI, it's become clear that this test is very flaky because it relies on requests not finishing quickly enough. For the first test, specifying a priority should ensure that tasks don't start running until they're all enqueued. For the second test, it's important that if the first `CustomerInfo` request had finished, we don't make a second one, which would make the test fail.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3584 +/- ##
==========================================
- Coverage 86.10% 86.10% -0.01%
==========================================
Files 242 242
Lines 17629 17629
==========================================
- Hits 15180 15179 -1
- Misses 2449 2450 +1 ☔ View full report in Codecov by Sentry. |
|
Included in #3140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/17208/workflows/729d01a6-d644-446c-8514-80b54177ff43/jobs/162052/tests
With #3140 and faster executors in CI, it's become clear that this test is very flaky because it relies on requests not finishing quickly enough.
For the first test, the new implementation ensures that all
customerInfocalls happen in parallel.For the second test, it's important that if the first
CustomerInforequest had finished, we don't make a second one, which would make the test fail.