Minor improvements #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -445,7 +445,7 @@ public Part setLocalizedText(String id, String... parameters) { | |||
| * @return this Part for chain calls | |||
| */ | |||
| public Part setLocalizedTextParameters(String... parameters) { | |||
| this.localizedTextParameters = parameters.length == 0 ? null : parameters; | |||
| this.localizedTextParameters = parameters == null || parameters.length == 0 ? null : parameters; | |||
There was a problem hiding this comment.
I'm really not sure about this. Can you pass a null object to this method? Doesn't it create a String array of length 1 with parameters[0] == null?
Maybe you can pass a null variable of type String[]. Would require testing maybe?
There was a problem hiding this comment.
This is possible to be null if you cast the null to String array or your variable of type String array is null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
return thistoMessage.set(int,Part)Fixed potential NPE in
Part.setLocalizedTextParameters(String...)