Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unescaped $ in template string throw unexpected EOF error #16

Closed
Conduitry opened this issue Jan 11, 2019 · 1 comment · Fixed by #18
Closed

Unescaped $ in template string throw unexpected EOF error #16

Conduitry opened this issue Jan 11, 2019 · 1 comment · Fixed by #18

Comments

@Conduitry
Copy link
Collaborator

Trying to transform the following valid javascript

let foo = `$`;

results in an exception from Shimport. As far as I can tell, the unescaped $ can appear anywhere in the string and cause this error. If an unescaped $ in a template string is not followed by a {, Shimport should just treat it like a regular character.
Rich-Harris added a commit that referenced this issue Apr 14, 2019
@Rich-Harris
handle dollar in template string - fixes #16
e9a6564
@Rich-Harris Rich-Harris mentioned this issue Apr 14, 2019
Merged
Rich-Harris added a commit that referenced this issue Apr 14, 2019
@Rich-Harris
Merge pull request #18 from Rich-Harris/gh-16
d2ad1c5 
handle dollar in template string
@Rich-Harris
Copy link
Owner

Fixed in 0.0.15 — thanks

@Conduitry Conduitry mentioned this issue Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle dollar in template string Rich-Harris/shimport
2 participants
@Rich-Harris @Conduitry