Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.0.15 regression "Unexpected end of file" #20

Closed
Conduitry opened this issue Apr 15, 2019 · 3 comments · Fixed by #21
Closed

0.0.15 regression "Unexpected end of file" #20

Conduitry opened this issue Apr 15, 2019 · 3 comments · Fixed by #21

Comments

@Conduitry
Copy link
Collaborator

I'm still digging through what causes this, but the current v3 svelte site throws an unexpected EOF error on Firefox. This is not present when manually switching back to 0.0.14.
@Conduitry
Copy link
Collaborator Author

It looks like the problem is now an EOF error whenever there is a template string with an embedded expression - the opposite of #16.

@Conduitry
Copy link
Collaborator Author 

let foo = `${42}`;

@Conduitry
Copy link
Collaborator Author

Ooh I think I've got it. PR coming ... soon-ish.

Rich-Harris added a commit that referenced this issue Apr 15, 2019
@Rich-Harris
handle template strings - fixes #20
14d8e51
@Rich-Harris Rich-Harris mentioned this issue Apr 15, 2019
Merged
Rich-Harris added a commit that referenced this issue Apr 15, 2019
@Rich-Harris
Merge pull request #21 from Rich-Harris/gh-20
c18224b 
handle template strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle template strings Rich-Harris/shimport
1 participant
@Conduitry