fix: revert if strategy contract does not implement method #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #396
📓 Overview
The governance proxy deployment should revert in case the input strategy contract does not implement the
assertValidInitParams
method. This is a remote scenario that only happens when a user accidentally inputs a rogue strategy contract address. However, as the deployment does not fail, it is an undesired behavior as the same user won't be able to deploy a governance with the same name. This is relevant for multi-chain governance.