Skip to content

Fix Batching Issues #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2020
Merged

Fix Batching Issues #113

merged 3 commits into from
Feb 14, 2020

Conversation

rolandszoke
Copy link
Member

@rolandszoke rolandszoke commented Feb 14, 2020 •
edited
Loading

#92

solkimicreb
solkimicreb requested changes Feb 14, 2020
View reviewed changes
Copy link
Collaborator

@solkimicreb solkimicreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I requested two small changes, the rest looks perfect.

@rolandszoke
fix(batch): flush even if error thrown inside batch
acc41f2 
use symbol for class component render triggering function
@coveralls
Copy link

coveralls commented Feb 14, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 96.538% when pulling 53e1eee on fix_batching into ac18e30 on master.

solkimicreb
solkimicreb approved these changes Feb 14, 2020
View reviewed changes
Copy link
Collaborator

@solkimicreb solkimicreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 thx

@solkimicreb solkimicreb merged commit 3cf2180 into master Feb 14, 2020
@solkimicreb solkimicreb deleted the fix_batching branch February 14, 2020 15:08
@luisherranz luisherranz mentioned this pull request Feb 15, 2020
Closed
3 tasks
@luisherranz luisherranz mentioned this pull request Mar 12, 2020
Closed
5 tasks
@rolandszoke
Copy link
Member Author

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solkimicreb solkimicreb solkimicreb approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolandszoke @coveralls @solkimicreb