Skip to content

Start locally linked example with npm scripts #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2020
Merged

Start locally linked example with npm scripts #122

merged 2 commits into from
Mar 5, 2020

Conversation

rolandszoke
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 2, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 95.522% when pulling 488fe9b on start-example into 877b1ab on master.

solkimicreb
solkimicreb requested changes Mar 2, 2020
View reviewed changes
Copy link
Collaborator

@solkimicreb solkimicreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this. Left a comment about swallowed cra logs.

solkimicreb
solkimicreb reviewed Mar 2, 2020
View reviewed changes
@rolandszoke rolandszoke requested a review from solkimicreb March 4, 2020 13:55
@solkimicreb solkimicreb merged commit ad47b30 into master Mar 5, 2020
@solkimicreb
Copy link
Collaborator

Thanks! This is pretty cool 😎

@solkimicreb solkimicreb deleted the start-example branch March 30, 2020 07:43
@rolandszoke
Copy link
Member Author

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solkimicreb solkimicreb solkimicreb approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolandszoke @coveralls @solkimicreb