Skip to content

Add displayName before React.memo for React devtools #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2020
Merged

Add displayName before React.memo for React devtools #126

merged 3 commits into from
Mar 13, 2020

Conversation

rolandszoke
Copy link
Member

#93

@rolandszoke rolandszoke requested a review from solkimicreb March 9, 2020 12:45
solkimicreb
solkimicreb requested changes Mar 12, 2020
View reviewed changes
Copy link
Collaborator

@solkimicreb solkimicreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move memo wrapping to the end of file instead and add a related docs section at the end of the Creating reactive views collapsable bullet points section. Thx!

@coveralls
Copy link

coveralls commented Mar 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 96.029% when pulling 030222b on fix_displayName into 7a0346f on master.

@rolandszoke rolandszoke requested a review from solkimicreb March 12, 2020 15:11
solkimicreb
solkimicreb requested changes Mar 13, 2020
View reviewed changes
Copy link
Collaborator

@solkimicreb solkimicreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect code and test wise. Added two comments to the docs.

@rolandszoke rolandszoke requested a review from solkimicreb March 13, 2020 14:27
@solkimicreb solkimicreb merged commit 8830963 into master Mar 13, 2020
@solkimicreb solkimicreb deleted the fix_displayName branch March 30, 2020 07:43
@rolandszoke
Copy link
Member Author

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solkimicreb solkimicreb solkimicreb approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolandszoke @coveralls @solkimicreb