Audit and update dependencies #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solkimicreb
reviewed
Mar 16, 2020
|
|
||
| const clearIntervalSpy = sinon.spy(global, 'clearInterval'); | ||
|
|
||
| afterAll(cleanup); |
There was a problem hiding this comment.
Out of curiosity? Why was this afterAll split required?
There was a problem hiding this comment.
I'm not sure, but @testing-library/dom changed, and If you do not add the cleanup directly to the afterAll or afterEach, but run it in a function (it does not matter if it is an arrow function or not) the cleanup will lose the scope of the document so it is unable to find the body and clean it up, and the function breaks.
There was a problem hiding this comment.
Ideally, we could have our tests isolated so we would not need to use cleanup at all. Maybe I should start working on it.
solkimicreb
requested changes
Mar 17, 2020
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.