Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add returning AST methods #135

Merged
merged 7 commits into from
Jan 31, 2016
Merged

Add returning AST methods #135

merged 7 commits into from
Jan 31, 2016

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Oct 18, 2015

Would resolve #133 and #130

This PR adds new methods:

@asgrim asgrim added this to the 1.0.0 milestone Oct 18, 2015
@asgrim asgrim mentioned this pull request Oct 28, 2015
Merged
@asgrim asgrim modified the milestones: 1.1.0, 1.0.0 Nov 2, 2015
Ocramius
Ocramius reviewed Jan 26, 2016
View reviewed changes
docs/ast-extraction.md

use BetterReflection\Reflector\ReflectionClass;

$classInfo = ReflectionClass::createFromName('Foo\Bar\MyClass');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using ::class in examples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 27025f3

@Ocramius
Copy link
Member

@asgrim needs rebase

@asgrim asgrim force-pushed the add-returning-ast-methods branch 2 times, most recently from 27025f3 to 2867791 Compare January 31, 2016 22:37
Ocramius added a commit that referenced this pull request Jan 31, 2016
@Ocramius
Merge pull request #135 from Roave/add-returning-ast-methods
c7ed859 
Add returning AST methods
@Ocramius Ocramius merged commit c7ed859 into master Jan 31, 2016
@Ocramius Ocramius deleted the add-returning-ast-methods branch January 31, 2016 23:02
This was referenced Jan 31, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Allow exporting a reflection to PHP
2 participants
@asgrim @Ocramius