Method body replacement #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,8 @@ | |||
| "nikic/php-parser": "dev-master", | |||
| "phpdocumentor/reflection-docblock": "^2.0", | |||
| "phpdocumentor/type-resolver": "dev-master", | |||
| "zendframework/zend-code": "^2.5@dev" | |||
| "zendframework/zend-code": "^2.5@dev", | |||
| "jeremeamia/superclosure": "dev-php-parser" | |||
There was a problem hiding this comment.
Needs replacing before merge
There was a problem hiding this comment.
(the version, not the whole dependency)
|
Note: I would not merge this until we first have a stable (tagged) API with the read-only part of better-reflection |
|
@Ocramius agreed. I just created |
asgrim
force-pushed
the
monkey-patching-methods
branch
2 times, most recently
from
0ff473f
to
72be51f
Compare
asgrim
force-pushed
the
monkey-patching-methods
branch
2 times, most recently
from
e3b02b7
to
74a39de
Compare
asgrim
changed the title
asgrim
force-pushed
the
monkey-patching-methods
branch
from
e79eadd
to
15fa288
Compare
asgrim
force-pushed
the
monkey-patching-methods
branch
2 times, most recently
from
db6dc72
to
3a738f4
Compare
… 7 because reasons
asgrim
force-pushed
the
monkey-patching-methods
branch
from
3a738f4
to
8120e79
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves part of #134 (ability to replace the statements within a function or method)
Note this requires PR #135 to be merged first, so do not merge please.Also depends on jeremeamia/super_closure#70(stable in 2.2.0+ now, which is used by our master now anyway)