Added test-case for deprecated phpstorm stub with patch-version

[staabm]

tests the ternary in

BetterReflection/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php

Line 677 in ab47d0b

$patch = $matches[3] ?? 0;

which wasn't covered before

[Ocramius]

which wasn't covered before

Was it an escaped / uncovered mutation?

[staabm]

Was it an escaped / uncovered mutation?

I don't know. I am not a mutation testing expert.

but I realized that this is a path which wasn't test-covered before while working on the PHPStan integration

[Ocramius]

I don't know. I am not a mutation testing expert.

I was more wondering if mainline caught it - should be visible in the MT framework output :D

[Ocramius]

(wrong button - thanks Github for not dong TAB+ENTER correctly)

[kukulich]

28ef29b

So I think there may be some escaped mutants now...

[Ocramius]

FWIW, in mainline:

6) /home/runner/work/BetterReflection/BetterReflection/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php:676    [M] IncrementInteger

--- Original
+++ New
@@ @@
         }
         if (preg_match('#@deprecated\\s+(\\d+)\\.(\\d+)(?:\\.(\\d+)?)$#m', $docComment->getText(), $matches) === 1) {
             $major = $matches[1];
-            $minor = $matches[2];
+            $minor = $matches[3];
             $patch = $matches[3] ?? 0;
             $versionId = sprintf('%d%02d%02d', $major, $minor, $patch);
             if ($this->phpVersion >= $versionId) {


7) /home/runner/work/BetterReflection/BetterReflection/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php:677    [M] DecrementInteger

--- Original
+++ New
@@ @@
         if (preg_match('#@deprecated\\s+(\\d+)\\.(\\d+)(?:\\.(\\d+)?)$#m', $docComment->getText(), $matches) === 1) {
             $major = $matches[1];
             $minor = $matches[2];
-            $patch = $matches[3] ?? 0;
+            $patch = $matches[2] ?? 0;
             $versionId = sprintf('%d%02d%02d', $major, $minor, $patch);
             if ($this->phpVersion >= $versionId) {
                 return true;


8) /home/runner/work/BetterReflection/BetterReflection/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php:677    [M] IncrementInteger

--- Original
+++ New
@@ @@
         if (preg_match('#@deprecated\\s+(\\d+)\\.(\\d+)(?:\\.(\\d+)?)$#m', $docComment->getText(), $matches) === 1) {
             $major = $matches[1];
             $minor = $matches[2];
-            $patch = $matches[3] ?? 0;
+            $patch = $matches[4] ?? 0;
             $versionId = sprintf('%d%02d%02d', $major, $minor, $patch);
             if ($this->phpVersion >= $versionId) {
                 return true;


9) /home/runner/work/BetterReflection/BetterReflection/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php:677    [M] DecrementInteger

--- Original
+++ New
@@ @@
         if (preg_match('#@deprecated\\s+(\\d+)\\.(\\d+)(?:\\.(\\d+)?)$#m', $docComment->getText(), $matches) === 1) {
             $major = $matches[1];
             $minor = $matches[2];
-            $patch = $matches[3] ?? 0;
+            $patch = $matches[3] ?? -1;
             $versionId = sprintf('%d%02d%02d', $major, $minor, $patch);
             if ($this->phpVersion >= $versionId) {
                 return true;


10) /home/runner/work/BetterReflection/BetterReflection/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php:677    [M] IncrementInteger

--- Original
+++ New
@@ @@
         if (preg_match('#@deprecated\\s+(\\d+)\\.(\\d+)(?:\\.(\\d+)?)$#m', $docComment->getText(), $matches) === 1) {
             $major = $matches[1];
             $minor = $matches[2];
-            $patch = $matches[3] ?? 0;
+            $patch = $matches[3] ?? 1;
             $versionId = sprintf('%d%02d%02d', $major, $minor, $patch);
             if ($this->phpVersion >= $versionId) {
                 return true;


11) /home/runner/work/BetterReflection/BetterReflection/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php:677    [M] Coalesce

--- Original
+++ New
@@ @@
         if (preg_match('#@deprecated\\s+(\\d+)\\.(\\d+)(?:\\.(\\d+)?)$#m', $docComment->getText(), $matches) === 1) {
             $major = $matches[1];
             $minor = $matches[2];
-            $patch = $matches[3] ?? 0;
+            $patch = 0 ?? $matches[3];
             $versionId = sprintf('%d%02d%02d', $major, $minor, $patch);
             if ($this->phpVersion >= $versionId) {
                 return true;

That should be OK with this patch now :)

This is mostly to show @staabm how to read this: I think MT is something that will be great for your testing toolbox, since you are so detail-oriented 💪

[Ocramius]

I don't see mutation changes here: I think your test scenario did not hit the edge case you were going for, as the mutations stayed the same :D

[staabm]

thanks for the explanation.

lets see whether we can kill some mainline mutants with nikic/PHP-Parser#985 :-)

[staabm]

FWIW, in mainline:

looking at the latest build of the latest 6.28.x-commit, I don't see the mutants you referenced in your comment

https://github.com/Roave/BetterReflection/actions/runs/8259610533/job/22593799759

[staabm]

ahh I think we don't catch a bug because we never reach the ELSE case of this condition (because CI is running only 8.2/8.3)

[Ocramius]

Ah, good catch! Indeed!

Perhaps we can change the fixture to introduce deprecations with higher/fictional PHP versions? :D

[staabm]

Let me first make sure phpstan can catch such bugs in the future. Brb

[staabm]

phpstan/phpstan-src#2968 should help us in the future.

[staabm]

superseded by #1408