Fix php version dependent constant deprecation #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
changed the title
|
I am afk. Will fix it later today |
staabm
commented
Mar 17, 2024
| \define('FILTER_SANITIZE_STRING', 513); | ||
| EOT; | ||
| $stubData = new StubData($exampleStub, 'filter'); | ||
| $stubData = $this->sourceStubber->generateConstantStub('MT_RAND_PHP'); |
There was a problem hiding this comment.
I am using a real constant now. using faked data the test did not cover reality
staabm
commented
Mar 17, 2024
| @@ -664,14 +679,14 @@ private function isCoreExtension(string $extension): bool | |||
| return in_array($extension, self::CORE_EXTENSIONS, true); | |||
| } | |||
|
|
|||
| private function isDeprecatedByPhpDocInPhpVersion(Node\Stmt\Const_ $node): bool | |||
| private function isDeprecatedByPhpDocInPhpVersion(Node\Expr\FuncCall $node): bool | |||
There was a problem hiding this comment.
in phpstorm stubs we use define('x', 1) and not const $x=1
Ocramius
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Indeed, the infection report looks:
-4164 mutations were generated:
+4170 mutations were generated:
- 3315 mutants were killed
+ 3333 mutants were killed
0 mutants were configured to be ignored
- 14 mutants were not covered by tests
+ 2 mutants were not covered by tests
10 covered mutants were not detected
- 7 errors were encountered
+ 6 errors were encountered
0 syntax errors were encountered
14 time outs were encountered
- 804 mutants required more time than configured
+ 805 mutants required more time than configured
Ocramius
added
enhancement
dependencies
|
Thanks @staabm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous test was running against PHP 8.1, which we don't run in CI.
thats the reason why it did not catch the implementation bug