Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev dependencies #11

Merged
merged 4 commits into from
Feb 8, 2019
Merged

Update dev dependencies #11

merged 4 commits into from
Feb 8, 2019

Conversation

BackEndTea
Copy link
Contributor

  • PHPUnit from 5.7 to 7.5 or 8.0+
  • Infection from 10.5 to 12.0

Only change needed was to use the 'new' TestCase, instead of PHPUnit_Framework_TestCase

@Ocramius
Copy link
Member

Ocramius commented Feb 8, 2019

Seems like the build failed...

@BackEndTea
Copy link
Contributor Author

Looks like newer phpunit versions dont allow interfaces for @covers, which makes sense as there is no coverage generated for those

BackEndTea added 2 commits February 8, 2019 12:19
Remove report useless tests option
806c9ae 
This is now default behaviour, and the flag has been removed
Link to local phpunit.xsd instead of a remote one
be521eb 
This should also help IDEs
Ocramius
Ocramius approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Ocramius Ocramius self-assigned this Feb 8, 2019
@Ocramius Ocramius added this to the 1.0.0 milestone Feb 8, 2019
@Ocramius Ocramius merged commit 2b98b51 into Roave:master Feb 8, 2019
@BackEndTea BackEndTea deleted the update/dependencies branch February 8, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@BackEndTea @Ocramius