Simplified exception message template #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved to a private constant to avoid method cluttering
asgrim
reviewed
Oct 11, 2016
| @@ -8,6 +8,16 @@ | |||
|
|
|||
| class NonSerialisableObject extends LogicException implements ExceptionInterface | |||
| { | |||
| private const ERROR_TEMPLATE = <<<'ERROR' | |||
There was a problem hiding this comment.
If it's a public const, surely you don't need to re-write it out in the test? Or is the reason explicitly to copy it to verify?
There was a problem hiding this comment.
Explicitly copying to verify. The package provides very little, besides meaningful exception messages, so I just did the additional step of verifying things there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved to a private constant to avoid method cluttering
Just making scrutinizer-ci happy, but also happy to play around with constant visibility, finally :-)