Updated signatures and return types to be compliant with PHP 8 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
reviewed
Dec 7, 2020
Co-authored-by: James Titcumb <james@asgrim.com>
|
Running infection in travis still fails because the code coverage cannot be created due to missing Xdebug mode coverage. |
asgrim
reviewed
Dec 7, 2020
Co-authored-by: James Titcumb <james@asgrim.com>
asgrim
approved these changes
Dec 7, 2020
|
@frankvanhest thank you Frank! LGTM, ignoring Scrutinizer as I think I removed that anyway :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should contain all the necessary changes to be compliant with PHP 8. Because it will be BC breaking, I think it should be tagged (if the PR is merged) as 2.0.0.
Let me know if further changes are needed.