Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Dont/ToString #32

Merged
merged 5 commits into from
Jan 7, 2021
Merged

add Dont/ToString #32

merged 5 commits into from
Jan 7, 2021

Conversation

afilina
Copy link
Contributor

@afilina afilina commented Jan 6, 2021 •
edited
Loading

Based on PR #19 by @OskarStark. Fixes #18.

  • Added documentation.
  • Fixed test coverage/mutation.
  • Removed travis config because the project moved to github actions.

Ocramius
Ocramius approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 thanks @OskarStark and @afilina!

@Ocramius Ocramius self-assigned this Jan 7, 2021
@Ocramius Ocramius added this to the 1.3.0 milestone Jan 7, 2021
@Ocramius Ocramius merged commit 8859d3b into Roave:1.3.x Jan 7, 2021
@Ocramius Ocramius mentioned this pull request Jan 7, 2021
Closed
@OskarStark
Copy link
Contributor

Thanks for taking over @afilina

@lexidor lexidor mentioned this pull request Jul 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

__toString()
3 participants
@afilina @OskarStark @Ocramius