Added DontInstantiate to the supported traits
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ocramius , any comments on this? Does this trait make sense for the library? |
|
Sorry @vudaltsov, I had totally missed reviewing this! |
Ocramius
changed the title
DontInstantiate to the supported traits
|
No problem, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for static helpers.
There are two ways to implement this:
final private constructor, which will natively throw an instance ofErroron instantiation attempt,final public constructorwith a customNonInstantiatableObjectexception like in other traits.I've decided to implement the first one, since it's a native approach and also PhpStorm automatically removes such classes from
new ...autocompletion.I didn't add
DontInstantiatetoJustDont, because it obviously breaks BC and also because it makesJustDontunusable in most situations.