Rename unserialize exception #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Oct 12, 2016
| @@ -1,11 +1,11 @@ | |||
| <?php | |||
There was a problem hiding this comment.
this test class should be renamed according to changes
| @@ -1,11 +1,11 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
| declare(strict_types = 1); | |||
There was a problem hiding this comment.
your IDE likely messed up the alignment here
| @@ -5,7 +5,7 @@ | |||
| namespace DontTest; | |||
There was a problem hiding this comment.
Same here - file/class to be renamed
| @@ -5,7 +5,7 @@ | |||
| namespace DontTest; | |||
|
|
|||
| use Dont\DontDeserialise; | |||
| use Dont\Exception\NonDeserialisableObject; | |||
| use Dont\Exception\ShouldNotUnserializeObject; | |||
|
|
|||
| /** | |||
| * @covers \Dont\DontDeserialise | |||
There was a problem hiding this comment.
Coverage annotations need adjustment
|
|
||
| namespace DontTest\Exception; | ||
|
|
||
| use Dont\Exception\ExceptionInterface; | ||
| use Dont\Exception\NonDeserialisableObject; | ||
| use Dont\Exception\ShouldNotUnserializeObject; | ||
| use Dont\Exception\TypeError; | ||
| use LogicException; | ||
| use stdClass; |
There was a problem hiding this comment.
Coverage annotations will need adjustments in here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why I put myself through this, let me know what you think @Ocramius and I will update the
serializeexception to match once it's merged (if that ever happens).