Adding DontClone feature

[nathanmarcos]

No description provided.

[GeeH]

This is really nice, but the trait should be named Clone so the FQNS is Dont\Clone as per issue 3.

[asgrim]

I was under the impression it should be DontClone (so more readable when importing the traits:)

namespace Bar;

use Dont\DontClone;

class Foo {
    use DontClone;
}

vs

namespace Bar;

use Dont\Clone;

class Foo {
    use Clone;
}

(the 2nd is less clear IMO)

[GeeH]

I'm only going by the README.md which you obviously haven't read. It states... that I am completely wrong and should be ignored. Sorry.

I would still prefer to see code such as:

namespace Asgrim\Sucks;

class MyEntity
{
    use \Dont\Clone;
}

[GeeH]

BTW I am 92.4% happy to be ignored on this opinion as it's person preference and either works fine.

[Ocramius]

@GeeH I discussed this with @macnibblet before, and I even experienced it in first place (in the test assets): basically, in most scenarios, most users will import the trait via a use statement, and having class Foo { use Clone; } will be confusing, while class Foo { use DontClone; } is much better.

[GeeH]

Agreed. I'm a moron.

On Tue, 11 Oct 2016 at 15:39 Marco Pivetta notifications@github.com wrote:

@Ocramius commented on this pull request.

In src/Dont/DontClone.php #5:

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Dont;
+
+use Dont\Exception\NonCloneableObject;
+use Dont\Exception\TypeError;
+
+trait DontClone

@GeeH https://github.com/GeeH I discussed this with @macnibblet
https://github.com/macnibblet before, and I even experienced it in
first place: basically, in most scenarios, most users will import the trait
via a use statement, and having class Foo { use Clone; } will be
confusing, while class Foo { use DontClone; } is much better.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#5, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAlcAD_ZrtqyvCbpLCuGmCFY6ewQ7MhJks5qy5-FgaJpZM4KTnCJ
.

[Ocramius]

Assigning to @asgrim for review - we can eventually look at this on Saturday.

[GeeH]

👍

[Ocramius]

👍