Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't __get or __set #8

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Don't __get or __set #8

merged 2 commits into from
Oct 25, 2018

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Oct 25, 2018

No description provided.

@asgrim asgrim added this to the 1.0.0 milestone Oct 25, 2018
Ocramius
Ocramius approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius self-assigned this Oct 25, 2018
@Ocramius Ocramius merged commit 9a6b8f4 into master Oct 25, 2018
@Ocramius Ocramius deleted the dont-get-or-set branch October 25, 2018 15:47
@Ocramius Ocramius changed the title Don't __get or __set Don't __get or __set Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@asgrim @Ocramius