Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace humbug with infection #9

Merged
merged 4 commits into from
Oct 25, 2018
Merged

Replace humbug with infection #9

merged 4 commits into from
Oct 25, 2018

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Oct 25, 2018

Humbug is dead. Long live infection.

@asgrim asgrim added this to the 1.0.0 milestone Oct 25, 2018
@Ocramius Ocramius self-assigned this Oct 25, 2018
Ocramius
Ocramius requested changes Oct 25, 2018
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@Ocramius Ocramius assigned asgrim and unassigned Ocramius Oct 25, 2018
@Ocramius
Copy link
Member 

                                                                                
 [ERROR] The minimum required MSI percentage should be 100%, but actual is 75%. 
         Improve your tests!

Hear hear!

Also, rebase plox.

@asgrim asgrim force-pushed the replace-humbug-with-infection branch from b0eddd6 to 7a969b3 Compare October 25, 2018 16:01
@asgrim asgrim assigned Ocramius and unassigned asgrim Oct 25, 2018
Ocramius
Ocramius approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 thanks @asgrim!

@Ocramius Ocramius merged commit ebbbc93 into master Oct 25, 2018
@Ocramius Ocramius deleted the replace-humbug-with-infection branch October 25, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@asgrim @Ocramius