Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Muting upload logs related to non-eligible requests #1733

Merged
merged 2 commits into from
May 6, 2024
Merged

Muting upload logs related to non-eligible requests #1733

merged 2 commits into from
May 6, 2024

Conversation

RobinTail
Copy link
Owner

No description provided.

@RobinTail RobinTail added the refactoring The better way to achieve the same result label May 6, 2024
@RobinTail RobinTail marked this pull request as ready for review May 6, 2024 14:20
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented May 6, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 74358fc on mute-non-eligible-upload-logging
into d27c59d on master.

RobinTail
RobinTail commented May 6, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit cc3fff8 into master May 6, 2024
11 checks passed
@RobinTail RobinTail deleted the mute-non-eligible-upload-logging branch May 6, 2024 14:31
RobinTail added a commit that referenced this pull request May 6, 2024
@RobinTail
Muting upload logs related to non-eligible requests (#1733)
729bf1f
@RobinTail RobinTail mentioned this pull request May 7, 2024
Merged
RobinTail added a commit that referenced this pull request May 7, 2024
@RobinTail
Exposing the expected request content type (#1739)
111f27e 
This should enable connecting uploader/raw parsers only to the endpoints
that really need it (initRouting).
Then can revert #1733
@RobinTail RobinTail mentioned this pull request May 7, 2024
Merged
RobinTail added a commit that referenced this pull request May 7, 2024
@RobinTail
Reverting #1733 and cc3fff8 (partially).
44fc73e
RobinTail added a commit that referenced this pull request May 8, 2024
@RobinTail
Feat: Selective parsers with child logger (#1741)
9cc3ec7 
Enabled by #1739 
Addressing v19

This PR does the following changes:
- connects only the selected parsers needed for particular endpoint
depending on its expected request type (json, raw, upload);
- provides those parsers and middlewares with a request-level (child)
logger;
- reverts #1733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail