Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing the expected request content type #1739

Merged
merged 6 commits into from
May 7, 2024
Merged

Exposing the expected request content type #1739

merged 6 commits into from
May 7, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented May 7, 2024 •
edited
Loading

This should enable connecting uploader/raw parsers only to the endpoints that really need it (initRouting).
Then can revert #1733

@RobinTail RobinTail added enhancement New feature or request refactoring The better way to achieve the same result labels May 7, 2024
@RobinTail
Copy link
Owner Author

The following changes might be breaking for the type beforeUpload hook, because currently it receives the whole app, while it should be receiving the arguments natural for a middleware.
Therefore it will be addressed in another PR targeting v19.

@RobinTail RobinTail marked this pull request as ready for review May 7, 2024 14:37
RobinTail
RobinTail commented May 7, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail changed the title Exposing the detected request content type Exposing the expected request content type May 7, 2024
@RobinTail RobinTail merged commit 111f27e into master May 7, 2024
11 checks passed
@RobinTail RobinTail deleted the endpoint-content-type branch May 7, 2024 14:58
@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 9889fbb on endpoint-content-type
into b0e5e89 on master.

@RobinTail RobinTail added this to the v19 milestone May 7, 2024
@RobinTail RobinTail mentioned this pull request May 7, 2024
Merged
RobinTail added a commit that referenced this pull request May 8, 2024
@RobinTail
Feat: Selective parsers with child logger (#1741)
9cc3ec7 
Enabled by #1739 
Addressing v19

This PR does the following changes:
- connects only the selected parsers needed for particular endpoint
depending on its expected request type (json, raw, upload);
- provides those parsers and middlewares with a request-level (child)
logger;
- reverts #1733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request refactoring The better way to achieve the same result
Projects
None yet
Milestone
v19
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail