Skip to content

Add module meta #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Add module meta #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6880874
Add module author to grid view
grandeljay Jan 9, 2023
7520d9b
Add module website
grandeljay Jan 9, 2023
87409f7
Refactor unnecessary methods
grandeljay Jan 11, 2023
c6a69c2
Fix outdated version
grandeljay Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/Templates/ModuleInfo.tmpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,21 +221,21 @@
<?php } ?>
</p>
</div>
</div>
</div>

<div class="tab-pane fade" id="v-pills-install" role="tabpanel" aria-labelledby="v-pills-install-tab">
<div class="markdown-body">
Wird geladen. Bitte warten...
</div>
</div>


<div class="tab-pane fade" id="v-pills-usage" role="tabpanel" aria-labelledby="v-pills-usage-tab">
<div class="markdown-body">
Wird geladen. Bitte warten...
</div>
</div>


<div class="tab-pane fade" id="v-pills-changes" role="tabpanel" aria-labelledby="v-pills-changes-tab">
<div class="markdown-body changelog">
Expand Down Expand Up @@ -294,6 +294,17 @@
</td>
</tr>

<tr>
<td>Website</td>
<td>
<?php if ($module->getWebsite()) { ?>
<a target="_blank" href="<?= $module->getWebsite() ?>"><?= $module->getWebsite() ?></a>
<?php } else { ?>
unbekannte Website
<?php } ?>
</td>
</tr>

<tr>
<td>Alle Versionen</td>
<td>
Expand Down
12 changes: 10 additions & 2 deletions src/Templates/ModuleListingModule.tmpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@

$modulePrice = $module->isInstalled() ? 'installiert' : $moduleView->getPriceFormated();
$moduleLink = '?action=moduleInfo&archiveName=' . $module->getArchiveName() . '&version=' . $module->getVersion();

$moduleDeveloper = $module->getDeveloper();
$moduleDeveloperWebsite = $module->getDeveloperWebsite();
?>

<div class="card module-serach-box <?= $module->isCompatible() ? 'compatible' : 'incompatible'; ?>" data-tags="<?= $dataTags ?>">
Expand All @@ -30,6 +31,13 @@
<h5 class="card-title">
<?= $module->getName(); ?>
<span class="card-version"><?= $module->getVersion(); ?></span>
<div class="card-developer">
<?php if ($moduleDeveloperWebsite) { ?>
<a href="<?= $moduleDeveloperWebsite; ?>"><?= $moduleDeveloper ?></a>
<?php } else { ?>
<?= $moduleDeveloper ?>
<?php } ?>
</div>
</h5>

<div class="module-price">
Expand All @@ -44,4 +52,4 @@

<a href="<?= $moduleLink ?>" class="btn <?= $module->isCompatible() ? 'btn-primary' : 'btn-secondary'; ?>">Details</a>
</div>
</div>
</div>
7 changes: 6 additions & 1 deletion src/Templates/Styles/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ select + p {

select.form-control {
height: 38px !important;
}
}

h1,
h2,
Expand Down Expand Up @@ -188,6 +188,11 @@ section {
color: var(--gray);
}

.modules .category .card .card-developer {
font-size: 0.8rem;
margin-top: 0.2rem;
}

.modules .category .card .module-price {
font-size: 1.25em;
color: var(--blue);
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/RemoteModuleLoaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function testCanLoadLatestVersionByArchiveName()
$module = $this->loader->loadLatestVersionByArchiveName('composer/autoload');

$this->assertEquals('composer/autoload', $module->getArchiveName());
$this->assertEquals('1.2.2', $module->getVersion());
$this->assertEquals('1.3.0', $module->getVersion());
}

public function testCanLoadByArchiveNameAndVersion()
Expand Down