-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access Control copy edits #13
Comments
@mnacinopa and I haven't been able to figure out how to properly disable it. Could one of you show us? |
Internal notes
|
SSH info
|
This is just an idea for new styling, although this content can be fitted into the current styling just fine. I can also send you the text in another document so you can copy/paste |
@victorevector questions
|
re: #13 (comment)
|
@peries
|
@victorevector |
@victorevector feedback for the latest version Within the wizard, Start
Access Control
SSH Control
Finish
|
EnablingTitle: Enable Security Features Are you sure you want to proceed? DisablingTitle: Disable Security Features Are you sure you want to proceed? |
@victorevector let's talk more about this notification when you can |
@peries @mnacinopa @AllenMcAfee @Ximidar I am currently adding the SSH enable/disable radio button to Pros:
Cons:
|
I believe they should only see the SSH option when they have access control enabled. having that option hidden behind a login would be nice. |
Will the Security Setup Wizard run automatically once someone navigates to the web dash after we push the update? The only way i can see this being a problem is for users who actually use SSH, and get blindsided. |
@mnacinopa The user will have to enable the Security Setup Wizard from |
@victorevector Okay thats fine. Once we push the update, will SSH just automatically be disabled for all users? |
@mnacinopa Per Allen's request yes |
@peries @mnacinopa @AllenMcAfee @Ximidar |
When Access Control is enabled, you cannot control the printer from the web dashboard unless you are logged in. Additionally, you can only access the API QR code from the logged in view of the web dashboard. This prevents unregistered users from accessing and using your printer via the internet or mobile app. We advise enabling Access Control when your printer is connected to an unsecure or shared network (such as a school or public places).
NOTE: If you lose your new password, you will need to contact Robo customer support. In which case, you risk losing all of the data on your printer.
|
@peries can we go ahead and make the link that is needed in the announcement window? I'll need to get that into this fix. |
@mnacinopa let us know when the article is updated |
@peries I fixed those two edits. Could you pull and test? |
Thanks Matt! Looks like everything has been resolved |
@victorevector @AllenMcAfee for your review
dev notes by victor
This text can be found in
src/octoprint/templates/dialogs/wizard/firstrun_start.jinja2
dev notes by victor
This text can be found in
src/octoprint/plugins/corewizard/templates/corewizard_acl_wizard.jinja2
dev notes by victor
Re: the html elements that are crossed out... The wizard dialog box is defined in the file
src/octoprint/templates/dialogs/wizard.jinja2
. Here are some (not all) options on how to edit them out.select html identifier and append a
display: none;
css rule.create "minimal" flag and code roboOctoprint to react to this flag; i.e. roboOctoprint chooses which wizard template to render depending on flag.
Relevant elements:
side bar:
previous button:
footer text:
next text:
The text was updated successfully, but these errors were encountered: