Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Control copy edits #13

Closed
peries opened this issue Nov 20, 2017 · 28 comments
Closed

Access Control copy edits #13

peries opened this issue Nov 20, 2017 · 28 comments
Assignees

Comments

@peries
Copy link
Contributor

peries commented Nov 20, 2017

@victorevector @AllenMcAfee for your review

1 copy

dev notes by victor
This text can be found in src/octoprint/templates/dialogs/wizard/firstrun_start.jinja2

2 copy

dev notes by victor
This text can be found in src/octoprint/plugins/corewizard/templates/corewizard_acl_wizard.jinja2

dev notes by victor
Re: the html elements that are crossed out... The wizard dialog box is defined in the file src/octoprint/templates/dialogs/wizard.jinja2. Here are some (not all) options on how to edit them out.

  • select html identifier and append a display: none; css rule.

  • create "minimal" flag and code roboOctoprint to react to this flag; i.e. roboOctoprint chooses which wizard template to render depending on flag.

Relevant elements:

  1. side bar:

    1. div#wizard_dialog_menu { display: none;}
    2. div.span3 --> div.span11
  2. previous button:

    1. div.modal-footer button.button-previous { display: none; }
  3. footer text:

    1. div.modal-footer div.text-center { display: none; }
  4. next text:

    1. div.modal-footer button.button-next
    2. use reactive html or js to change the text value based on modal content or button event.
@peries
Copy link
Contributor Author

peries commented Nov 20, 2017

@mnacinopa and I haven't been able to figure out how to properly disable it. Could one of you show us?

@victorevector
Copy link
Contributor

Internal notes

@victorevector
Copy link
Contributor

SSH info

  • An advanced user wants to enable SSH (default: disabled).

  • A user wants to know the implications of turning it on.

    • Any remote user with the printer's username and password can control the printer.
  • A user wants to know the default password.

    • username: pi password:
  • A user wants to know how to change the default password.

@peries
Copy link
Contributor Author

peries commented Nov 28, 2017

@peries
Copy link
Contributor Author

peries commented Nov 28, 2017

and then if they've already created an account,
access control 1

@peries
Copy link
Contributor Author

peries commented Nov 29, 2017

This is just an idea for new styling, although this content can be fitted into the current styling just fine. I can also send you the text in another document so you can copy/paste

@peries
Copy link
Contributor Author

peries commented Nov 29, 2017

@victorevector questions

  1. can the 'access control' screens be dynamic such that it knows if you've created an admin account already?
  2. can the 'setup complete' screen be dynamic such that it shows which selections you've just made (so you can confirm) before finishing the wizard?

@victorevector
Copy link
Contributor

victorevector commented Nov 29, 2017

@peries

re: #13 (comment)

  1. The setup wizard does display a different interface if an admin account has already been registered.

  2. I can carry over the values to the end screen. It does raise questions about "confirmation". Once you enable access control you can't undo it. Another thing, I think the surest way to reset an admin password is to reflash the whole OS.

@mnacinopa
Copy link

mnacinopa commented Dec 13, 2017

@peries
The only things to edit

  • The default username is actually pi, I think?
  • At the Enable/Disable Screens we need to warn them this will restart their printer and interrupt any print jobs going on

@mnacinopa
Copy link

@victorevector
When there are multiple user accounts can only the admin acc enable/disable access control & ssh?

@peries
Copy link
Contributor Author

peries commented Dec 14, 2017

@victorevector feedback for the latest version

Within the wizard,

Start

  • second paragraph copy edit: If you're a new user, we'd like to welcome you to the Robo family! If you've been here before, we'll take you through some newly added settings.
  • delete previous button
  • delete 'unless otherwise noted..." line
  • change next button text to 'start'

Access Control

  • Note copy edit: NOTE: If you lose your new password, you will need to contact Robo customer support. In which case, you risk losing all of the data on your printer.
  • delete previous button
  • delete 'unless otherwise noted..." line

SSH Control

  • Change sidebar to say 'SSH Control' instead of wizard
  • Change title to say 'SSH Control'
  • Delete apostrophe in it's
  • Delete extra space after einstein
  • Add period after closed parentheses
  • Copy edit to the last line of the last paragraph: If you keep SSH disabled, there is no need to change your password.
  • delete 'unless otherwise noted..." line
  • change previous button text to 'go back'

Finish

  • delete 'unless otherwise noted..." line
  • change previous button text to 'go back'

@peries
Copy link
Contributor Author

peries commented Dec 14, 2017

Enabling

capture000

Title: Enable Security Features
Body: You are about to launch the setup wizard to enable remote access security features. You will have to complete the wizard in order to continue using the web dashboard. The dashboard and your printer will automatically restart once the wizard is finished. This will disrupt any active prints.

Are you sure you want to proceed?

Disabling

capture0000

Title: Disable Security Features
Body: You are about to disable the remote access security features and DELETE all user accounts. This will make your printer remotely accessible to everyone within your local network. The dashboard and your printer will automatically restart. This will disrupt any active prints.

Are you sure you want to proceed?

@peries
Copy link
Contributor Author

peries commented Dec 14, 2017

Can we change the text of the errors that this screen reports?
capture00000

Title: Enter valid username and password
Body: Please properly fill out the username and password forms
Invalid username
Invalid password
Passwords do not match
Button: OK

@peries
Copy link
Contributor Author

peries commented Dec 14, 2017

@victorevector let's talk more about this notification when you can

capture0

@victorevector
Copy link
Contributor

@peries @mnacinopa @AllenMcAfee @Ximidar

I am currently adding the SSH enable/disable radio button to Settings > Access Control. This made sense to me given that the option is originally bundled with Access Control in the Security Setup Wizard. The only caveat is that you can only see Settings > Access Control if you've enabled Access Control. What are your thoughts?

Pros:

  • Added security layer in front of SSH. You must be logged in with an admin account to enable/disable SSH

Cons:

  • The default state (disabled) cannot be changed unless you run the Security Setup Wizard OR you enable Access Control

@Ximidar
Copy link
Contributor

Ximidar commented Dec 14, 2017

I believe they should only see the SSH option when they have access control enabled. having that option hidden behind a login would be nice.

@mnacinopa
Copy link

Will the Security Setup Wizard run automatically once someone navigates to the web dash after we push the update? The only way i can see this being a problem is for users who actually use SSH, and get blindsided.

@victorevector
Copy link
Contributor

@mnacinopa The user will have to enable the Security Setup Wizard from System menu drop down

@mnacinopa
Copy link

mnacinopa commented Dec 14, 2017

@victorevector Okay thats fine. Once we push the update, will SSH just automatically be disabled for all users?

@victorevector
Copy link
Contributor

@mnacinopa Per Allen's request yes

@victorevector
Copy link
Contributor

@peries @mnacinopa @AllenMcAfee @Ximidar
I won't be able to add the SSH enable/disable button the Settings today. I've tried for a couple hours now and I don't have the proper environment to test it out. I'll have something ready once I'm back in the office next week.

@peries
Copy link
Contributor Author

peries commented Dec 22, 2017

@victorevector

  1. Access control screen in the wizard, there's a couple typos
  • Since we didn't explain the QR code and mobile app, can you change the first paragraph to

When Access Control is enabled, you cannot control the printer from the web dashboard unless you are logged in. Additionally, you can only access the API QR code from the logged in view of the web dashboard. This prevents unregistered users from accessing and using your printer via the internet or mobile app. We advise enabling Access Control when your printer is connected to an unsecure or shared network (such as a school or public places).

  • Can you change the note to say

NOTE: If you lose your new password, you will need to contact Robo customer support. In which case, you risk losing all of the data on your printer.

  1. When access control is enabled, the text for the button to disable it is gone
    capture

  2. The password to SSH is raspberry. Is this gonna change?

  3. for the notification
    capture0

  • we need to link that top line to the article that explains access control. https://help.robo3d.com/hc/en-us/articles/115002840791
  • How to activate? Go to Settings, then 'Enable remote access security feature' to launch the setup wizard.
  • What's inside this feature? Restrict control of the printer via internet access (web dashboard, mobile app, SSH)

@AllenMcAfee
Copy link
Contributor

@peries can we go ahead and make the link that is needed in the announcement window? I'll need to get that into this fix.

@peries
Copy link
Contributor Author

peries commented Jan 4, 2018

@mnacinopa let us know when the article is updated

@peries
Copy link
Contributor Author

peries commented Jan 5, 2018

@peries
Copy link
Contributor Author

peries commented Jan 8, 2018

Couple more things where the text is highlighted:
ac1
should say 'or the Robo mobile app'

ac2
should say 'password is 'raspberry''

Ximidar added a commit that referenced this issue Jan 8, 2018
@Ximidar
Copy link
Contributor

Ximidar commented Jan 8, 2018

@peries I fixed those two edits. Could you pull and test?

@peries
Copy link
Contributor Author

peries commented Jan 9, 2018

Thanks Matt! Looks like everything has been resolved

@Ximidar Ximidar closed this as completed Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants