-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downstream Python test. #85
Add downstream Python test. #85
Conversation
+@fbudin69500 for feature review, please (if you have time). Review status: 0 of 3 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
FYI I am fine with having Shambhala have as many tests as we want, but in general we should have the Drake self-tests catch things like this pre-merge to the extent practical. |
82779b9
to
7e26288
Compare
Updated since RobotLocomotion/drake#7809 is fixed. |
Reviewed 3 of 3 files at r1. drake_cmake_installed/CMakeLists.txt, line 44 at r1 (raw file):
find_package(PythonInterp 2.7 EXACT MODULE REQUIRED) drake_cmake_installed/CMakeLists.txt, line 46 at r1 (raw file):
drake_cmake_installed/CMakeLists.txt, line 48 at r1 (raw file):
This functionality does exist in CMake, so not an actionable TODO unless you want us to add the functionality and move to a newer CMake (which I doubt you do just for this). drake_cmake_installed/src/find_resource/CMakeLists.txt, line 45 at r1 (raw file):
drake_cmake_installed/src/find_resource/CMakeLists.txt, line 49 at r1 (raw file):
drake_cmake_installed/src/find_resource/test_find_resource.py, line 1 at r1 (raw file):
We don't need a shebang. Replace with
drake_cmake_installed/src/find_resource/test_find_resource.py, line 6 at r1 (raw file):
Do we need all these imports? Comments from Reviewable |
b49e7a2
to
28f716c
Compare
Review status: 0 of 3 files reviewed at latest revision, 7 unresolved discussions. drake_cmake_installed/CMakeLists.txt, line 44 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Done. drake_cmake_installed/CMakeLists.txt, line 46 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Done. drake_cmake_installed/CMakeLists.txt, line 48 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Done. drake_cmake_installed/src/find_resource/CMakeLists.txt, line 45 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
I see no difference - can I ask what the defect is? (added a linebreak for wrapping) drake_cmake_installed/src/find_resource/CMakeLists.txt, line 49 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Done. drake_cmake_installed/src/find_resource/test_find_resource.py, line 1 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Done. drake_cmake_installed/src/find_resource/test_find_resource.py, line 6 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Done. Comments from Reviewable |
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. drake_cmake_installed/src/find_resource/CMakeLists.txt, line 45 at r1 (raw file): Previously, EricCousineau-TRI wrote…
Sorry, I meant to add double quotes.
|
28f716c
to
04125e0
Compare
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. drake_cmake_installed/src/find_resource/CMakeLists.txt, line 45 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
Done. Comments from Reviewable |
Reviewed 3 of 3 files at r2, 1 of 1 files at r3. Comments from Reviewable |
Currently the resource in question is broken.
Relates #9
This change is