Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround rviz_ogre_vendor not finding RenderSystem_GL.so #188

Conversation

sloretz
Copy link
Collaborator

@sloretz sloretz commented Nov 3, 2022

This fixes one last issue when using the tarball from https://build.ros2.org/view/Hci/job/Hci__nightly-cyclonedds_ubuntu_jammy_amd64/

The same issue happens on the ROS 2 buildfarm, but nothing is trying to use those targets so it's gone unnoticed. It went noticed here because the bazel_ros2_rules was trying to look for the libraries from those targets so that it could include them in the sandboxing. I'll also open a PR with a fix upstream.

This is the source of the console spam in Anzu.

EDIT: See ros2/rviz#920 for discussion and root-cause analysis (most likely a breaking CMake change)


This change is Reviewable

Copy link
Collaborator Author

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@EricCousineau-TRI for review please! This should fix the console spam on Jammy.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @EricCousineau-TRI)

Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong: per testing as indicated in Anzu PR 9787

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sloretz)

a discussion (no related file):
FYI From looking at upstream PR per your discussion w/ Chris, this overview may no longer be accurate.
I will remove the (possibly) inaccurate portions and refer readers to upstream PR.

Thanks!


@EricCousineau-TRI EricCousineau-TRI merged commit aa0b9c9 into RobotLocomotion:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants