Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camera_properties: Support setting with intrinsic matrix, possibly using CameraInfo #11880

Closed
EricCousineau-TRI opened this issue Jul 31, 2019 · 2 comments · Fixed by #14376
Closed
Assignees
Labels
component: geometry perception How geometry appears in color, depth, and label images (via the RenderEngine API) priority: medium unused team: dynamics

Comments

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented Jul 31, 2019

Would like this to supersede #8850. @SeanCurtis-TRI I've assigned you for now given that it supersedes that issue, but can reassign if you'd like. (I could also reword that issue if you'd like.)

Regarding this TODO comment:

// TODO(eric.cousineau): Make this have `CameraInfo` as a member, move that
// class outside of `drake::systems`, and possibly rename this class, in order
// to decouple generic pinhole parameters from Drake-specific render engine
// information.

Potential solutions could be actually using CameraInfo, or making a static factory method or something that takes an intrinsic matrix.

For renderer support, I'm fine if a renderer currently chokes if it can't support a set of intrinsics (either a non-central principal point, unequal fx + fy, skew, etc.).

\cc @thduynguyen Part of this could also involve adding back-projection utilities like what you requested, and then possibly have Anzu use this structure?

(Bringing this up with minor relevance to #11878)

@SeanCurtis-TRI
Copy link
Contributor

SeanCurtis-TRI commented Jun 12, 2020

Ok, I'm ready to start submitting PRs against this. The effort to do this is going to come in multiple phases. The overall result can be found here: https://github.com/SeanCurtis-TRI/drake/tree/PR_camera_intrinsics (Edit: Original branch has gone stale and is no longer representative, and doesn't even guarantee to exist anymore.)

Here's the plan:

------ everything above the line implemented in the linked branch; everything below still to be done -----

(The first PR should be submitted on 6/15/2020.)

@EricCousineau-TRI
Copy link
Contributor Author

Woot for the PR 🚅!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: geometry perception How geometry appears in color, depth, and label images (via the RenderEngine API) priority: medium unused team: dynamics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants