Fixes AddForceElement deprecation message #11529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcastro-tri
commented
May 23, 2019
There was a problem hiding this comment.
+@sammy-tri for feature review please.
Reviewable status: LGTM missing from assignee sammy-tri(platform), needs at least two assigned reviewers (waiting on @sammy-tri)
sammy-tri
approved these changes
May 23, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: needs at least two assigned reviewers
sammy-tri
approved these changes
May 23, 2019
There was a problem hiding this comment.
I'm not sure this needs a second reviewer? Go ahead and add the "single reviewer ok" flag and merge if you'd like.
Reviewable status: needs at least two assigned reviewers
amcastro-tri
added
the
status: single reviewer ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecation message for the overload adding a UniformGravityFieldElement.
This change is