Add python binding for MathematicalProgram::AddIndeterminates() and AddDecisionVariables() #12017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddDecisionVariables()
hongkai-dai
commented
Sep 6, 2019
There was a problem hiding this comment.
+@EricCousineau-TRI for both reviews please, thanks!
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform), needs at least two assigned reviewers (waiting on @EricCousineau-TRI)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: needs at least two assigned reviewers
hongkai-dai
commented
Sep 9, 2019
There was a problem hiding this comment.
+@jwnimmer-tri for reviews please. For some reason reviewable doesn't think I have added Eric as the reviewer.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform) (waiting on @jwnimmer-tri)
jwnimmer-tri
added
the
status: single reviewer ok
|
Eric should have added "status: single reviewer okay" label. I've done that now, so removing myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is