Improve args and doc for pyplot_visualizer #12915
Conversation
There was a problem hiding this comment.
+@EricCousineau-TRI for both reviews, please.
Reviewable status: LGTM missing from assignee EricCousineau-TRI(platform), needs at least two assigned reviewers (waiting on @EricCousineau-TRI)
RussTedrake
added
the
status: single reviewer ok
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion (waiting on @RussTedrake)
bindings/pydrake/systems/pyplot_visualizer.py, line 123 at r1 (raw file):
know the draw_period passed into the constructor exactly matches the sample timestep of the log. repeat: Whether the resulting animation should repeat.
nit Can you change this to state that all additional kwargs are passed to FuncAnimation?
RussTedrake
force-pushed
the
pyplot_tweaks
branch
from
1392dc8
to
2769222
Compare
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform) (waiting on @EricCousineau-TRI)
bindings/pydrake/systems/pyplot_visualizer.py, line 123 at r1 (raw file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
nit Can you change this to state that all additional
kwargsare passed toFuncAnimation?
Done. Good catch.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
This change is