throw error when the constraint lower and upper bounds size don't match. #13004
Conversation
There was a problem hiding this comment.
+@TobiaMarcucci for feature review please, thanks!
Reviewable status: LGTM missing from assignee TobiaMarcucci, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on @TobiaMarcucci)
There was a problem hiding this comment.
+@jwnimmer-tri 
Reviewed 4 of 4 files at r1.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee TobiaMarcucci (waiting on @hongkai-dai and @TobiaMarcucci)
solvers/constraint.cc, line 65 at r1 (raw file):
void Constraint::check(int num_constraints) const { static_cast<void>(num_constraints);
nit This static_cast line serves no purpose anymore.
There was a problem hiding this comment.
Reviewable status: LGTM missing from assignee TobiaMarcucci, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri and @TobiaMarcucci)
solvers/constraint.cc, line 65 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
nit This static_cast line serves no purpose anymore.
Good call. Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: LGTM missing from assignee TobiaMarcucci, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @TobiaMarcucci)
There was a problem hiding this comment.
Everything looks fine to my eyes. Thanks for adding this!
Reviewable status: LGTM missing from assignee TobiaMarcucci, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @TobiaMarcucci)
There was a problem hiding this comment.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @TobiaMarcucci)
hongkai-dai
added
the
status: squashing now
This change is