-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throw error when the constraint lower and upper bounds size don't match. #13004
throw error when the constraint lower and upper bounds size don't match. #13004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@TobiaMarcucci for feature review please, thanks!
Reviewable status: LGTM missing from assignee TobiaMarcucci, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on @TobiaMarcucci)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@jwnimmer-tri platform.
Reviewed 4 of 4 files at r1.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee TobiaMarcucci (waiting on @hongkai-dai and @TobiaMarcucci)
solvers/constraint.cc, line 65 at r1 (raw file):
void Constraint::check(int num_constraints) const { static_cast<void>(num_constraints);
nit This static_cast line serves no purpose anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: LGTM missing from assignee TobiaMarcucci, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri and @TobiaMarcucci)
solvers/constraint.cc, line 65 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
nit This static_cast line serves no purpose anymore.
Good call. Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: LGTM missing from assignee TobiaMarcucci, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @TobiaMarcucci)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine to my eyes. Thanks for adding this!
Reviewable status: LGTM missing from assignee TobiaMarcucci, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @TobiaMarcucci)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @TobiaMarcucci)
This change is