setup: On Bionic, the kcov dependency is now opt-in #13462
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jwnimmer-tri
force-pushed
the
bionic-kcov-optional
branch
from
9cb2317
to
6bc23e1
Compare
|
@drake-jenkins-bot linux-bionic-unprovisioned-gcc-bazel-experimental-release please |
|
+@jamiesnape for feature review, please. |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers
jwnimmer-tri
force-pushed
the
bionic-kcov-optional
branch
from
6bc23e1
to
c9a51a1
Compare
|
+@SeanCurtis-TRI for platform review per schedule, please. |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: 1 unresolved discussion, labeled "do not merge" (waiting on @jwnimmer-tri)
setup/ubuntu/source_distribution/install_prereqs.sh, line 27 at r2 (raw file):
# On Bionic, developers must opt-in to kcov support; it comes in with the # non-standard package name kcov-35 via a Drake-specific PPA
nit: punctuation at the end of the sentence.
jwnimmer-tri
force-pushed
the
bionic-kcov-optional
branch
from
c9a51a1
to
db19c12
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: 1 unresolved discussion, labeled "do not merge" (waiting on @jwnimmer-tri)
|
Skipping most rebuilds after a bash-comment-only push. |
This resolves the immediate problem of
drake-apt.csail.mit.educertificate "expiry" (for buggy clients).However, it is also a useful improvement towards #13168 optional prerequisites. While the mechanism of this may change (
--with-kcovspelling), the idea that extra developer tools should be opt-in is one that should remain.Relates #13475.
This change is