Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force older and newer yaml.dump to give the same output #13543

Merged
merged 1 commit into from Jun 15, 2020
Merged

Force older and newer yaml.dump to give the same output #13543

merged 1 commit into from Jun 15, 2020

Conversation

ggould-tri
Copy link
Contributor

@ggould-tri ggould-tri commented Jun 11, 2020 •
edited by sherm1

This change is Reviewable

@ggould-tri
Copy link
Contributor Author

@drake-jenkins-bot mac-mojave-clang-bazel-continuous-release please
@drake-jenkins-bot linux-focal-gcc-bazel-experimental-release please

@ggould-tri
Copy link
Contributor Author

@drake-jenkins-bot mac-mojave-clang-bazel-experimental-everything-release please.

@ggould-tri
Force older and newer yaml.dump to give the same output
668ddad 
* pyyaml changed its default flow semantics in yaml/pyyaml#256
* We must override the default with the magic tribool value `None`
* Fixes RobotLocomotion#13541
@ggould-tri
Copy link
Contributor Author

@drake-jenkins-bot mac-mojave-clang-bazel-experimental-everything-release please.
@drake-jenkins-bot linux-focal-gcc-bazel-experimental-release please

ggould-tri
ggould-tri commented Jun 15, 2020
View reviewed changes
Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri This reverts your #13538 nerfing of #13375 that resulted from #13541

Reviewable status: LGTM missing from assignee jwnimmer-tri(platform) (waiting on @jwnimmer-tri)

jwnimmer-tri
jwnimmer-tri reviewed Jun 15, 2020
View reviewed changes
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: feature.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform), exempt from platform review

@ggould-tri ggould-tri merged commit 43a28f9 into RobotLocomotion:master Jun 15, 2020
@jwnimmer-tri
Copy link
Collaborator

For the record... a fix forward for #13375.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwnimmer-tri jwnimmer-tri jwnimmer-tri left review comments

Assignees

@jwnimmer-tri jwnimmer-tri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mac/focal yaml serialization differs from bionic's
2 participants
@ggould-tri @jwnimmer-tri